Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to use PyGitHub for more capabilities #23

Closed
astrochun opened this issue Mar 25, 2021 · 1 comment · Fixed by #56
Closed

Switch over to use PyGitHub for more capabilities #23

astrochun opened this issue Mar 25, 2021 · 1 comment · Fixed by #56
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@astrochun
Copy link
Owner

We are using simple requests with the GitHub API. For improvements we should consider switching to PyGithub

@astrochun astrochun added the enhancement New feature or request label Mar 25, 2021
@astrochun astrochun added this to the v0.4.0 milestone Mar 25, 2021
@astrochun astrochun self-assigned this Mar 25, 2021
@astrochun
Copy link
Owner Author

astrochun commented May 10, 2021

I managed to get PyGitHub installed and ran it and here are the timeit results.

In [2]: %timeit -n1 -r5 repo_list.get_repo_list('astrochun')                                                                                          
618 ms ± 298 ms per loop (mean ± std. dev. of 5 runs, 1 loop each)

In [3]: %timeit -n1 -r5 repo_list.get_repo_list_old('astrochun')                                                                                      
354 ms ± 210 ms per loop (mean ± std. dev. of 5 runs, 1 loop each)

Not surprisingly, for getting just metadata about repository, the old way is faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant