Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalized Domain Names #10

Closed
Anonymous142 opened this issue Feb 7, 2018 · 4 comments · Fixed by #55
Closed

Internationalized Domain Names #10

Anonymous142 opened this issue Feb 7, 2018 · 4 comments · Fixed by #55
Labels
enhancement New feature or request

Comments

@Anonymous142
Copy link

http://www.청와대.한국
http://한글코딩.org
http://내도메인.한국

in these domains are not invalid.
for ex) 한글코딩.org##div

of course we can use like this
xn--bj0bv9kgwxoqf.org##div

i'm not sure.. but it seems not bad to have a think about it.

@ameshkov
Copy link
Member

ameshkov commented Feb 7, 2018

As I recall, not every ad blocker support Unicode domain names, and this extension is supposed to help you create filters whichever ad blocker you use.

Generally, I'd suggest to use Punycode and add a comment with the Unicode domain name. Something like this:

! 한글코딩.org
xn--bj0bv9kgwxoqf.org##div

@Anonymous142
Copy link
Author

i got it. ublock origin supports, but other ad blockers could not support..
thank you.

@ameshkov
Copy link
Member

ameshkov commented Feb 8, 2018

Tbh, I thought it does not. if so, all the major ad blockers do support unicode domain names and we'd better reopen it.

@ameshkov ameshkov reopened this Feb 8, 2018
@ameshkov ameshkov added the enhancement New feature or request label Feb 8, 2018
@Crystal-RainSlide
Copy link

As I've seen punycode.js in Adblock, AdBlock Plus and ublock Origin's source, I think most adblockers support this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants