From 879b110c76dd0fa46767343d5f39f50f598da797 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 24 Feb 2023 09:16:17 +0800 Subject: [PATCH] fix: l10n and todos --- .../presentation/widgets/float_bubble/question_bubble.dart | 5 +---- .../src/service/shortcut_event/built_in_shortcut_events.dart | 5 ++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart b/frontend/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart index 05ec839654c3..89b2976bc706 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/widgets/float_bubble/question_bubble.dart @@ -187,10 +187,7 @@ extension QuestionBubbleExtension on BubbleAction { case BubbleAction.debug: return LocaleKeys.questionBubble_debug_name.tr(); case BubbleAction.shortcuts: - // return LocaleKeys.questionBubble_shortcuts.tr(); - - // TODO: Use localized approach - return "Shortcuts"; + return LocaleKeys.questionBubble_shortcuts.tr(); } } diff --git a/frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart b/frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart index 6151042e52eb..6c1c7bc259e1 100644 --- a/frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart +++ b/frontend/appflowy_flutter/packages/appflowy_editor/lib/src/service/shortcut_event/built_in_shortcut_events.dart @@ -49,16 +49,15 @@ List builtInShortcutEvents = [ command: 'shift+arrow down', handler: cursorDownSelect, ), - // TODO: Use Unique and correct key names here ShortcutEvent( - key: 'Cursor down select', + key: 'Cursor left word select', command: 'shift+alt+arrow left', windowsCommand: 'shift+alt+arrow left', linuxCommand: 'shift+alt+arrow left', handler: cursorLeftWordSelect, ), ShortcutEvent( - key: 'Cursor down select', + key: 'Cursor right word select', command: 'shift+alt+arrow right', windowsCommand: 'shift+alt+arrow right', linuxCommand: 'shift+alt+arrow right',