Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureCommand module not working properly on windows #1423

Closed
4dri4anxD opened this issue Jul 18, 2024 · 1 comment · Fixed by #1426
Closed

SecureCommand module not working properly on windows #1423

4dri4anxD opened this issue Jul 18, 2024 · 1 comment · Fixed by #1426

Comments

@4dri4anxD
Copy link

4dri4anxD commented Jul 18, 2024

Problem description:
When trying to remove public keys from a flight controller running ardupilot firmware I ran this command "module load SecureCommand" and got "Please install monocypher with: python3 -m pip install pymonocypher" message.
pymonocypher is already installed via "py -m pip install pymonocypher".
It seems like pymonocypher is not being included by default when building.

Expected behavior:
When running "module load SecureCommand" command it should load the module without no problems.

Current behavior:
Got "Please install monocypher with: python3 -m pip install pymonocypher" message after running the command.

Operating system:
Windows 10

Python version:
3.12.14

pip version:
24.0

Steps to reproduce

  1. Download and install the latest release of MavProxy for windows
  2. Connect a Flight Controller to the Computer by USB
  3. Open a command prompt window
  4. Run "mavproxy --master=COMx" command (x is replaced by the port assigned to the flight controller)
  5. Run "module load SecureCommand"

Workaround:
Digging a little I found this comment which says that mavlink does not use the python environment on windows, thus, external libraries needs to be pasted in the MavProxy/_internal/ directory.
So I copied and pasted pymonocypher library folder and .pyd file into the MavProxy/_internal/ directory and then ran module load SecureCommand but got the same error message.
Then I built mavproxy v1.8.70 (by running MAVProxyWinBuild.bat file) and then copied and pasted the same library folder and the .pyd file into MavProxy/_internal/ directory and then ran SecureCommand and it worked.
At first I got Mavproxy v1.8.69 from here (the latest release windows installer).

@stephendade
Copy link
Contributor

It seems like pymonocypher is not being included by default when building.

Correct, it's not currently included. I'll need to find a way to collate all the various module requirements into a single place and reference that in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants