Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XCM integration tests #960

Closed
shaunxw opened this issue Jun 19, 2023 · 5 comments
Closed

Add XCM integration tests #960

shaunxw opened this issue Jun 19, 2023 · 5 comments
Assignees
@gitofdeepanshu
Labels
enhancement New feature or request project Issue is part of an ongoing project tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.

Comments

@shaunxw
Copy link
Member

shaunxw commented Jun 19, 2023

We currently have xcm-simulator-tests, which is not ideal as it's based on a mock runtime duplicating Shiden runtime. Instead, all runtimes including Shibuya/Shiden/Astar should be covered and the tests should be done against real-life relay chain and parachain runtimes.

There are 2 options for us:

  1. Chopsticks
    • Pros: test on live network forks, is able to cover more scenarios like HRMP channels, between runtimes with different XCM/deps version.
    • Cons: tests are written with TS/JS.
  2. XCM emulator
    • Pros: written in Rust.
    • Cons: cannot test HRMP channels; runtimes need to be the same deps version; will introduce extra build overhead for tests, CI.
@shaunxw shaunxw added enhancement New feature or request tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc. labels Jun 19, 2023
@gitofdeepanshu gitofdeepanshu self-assigned this Jun 21, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 22, 2023
@Dinonard Dinonard removed the Stale label Jul 24, 2023
@Dinonard
Copy link
Member

Emulator added via this uplift: #978

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 24, 2023
@shaunxw shaunxw removed the Stale label Aug 25, 2023
@Dinonard Dinonard added the project Issue is part of an ongoing project label Aug 31, 2023
@ermalkaleci
Copy link
Contributor

@Dinonard @shaunxw I believe this is already solved

@Dinonard
Copy link
Member

True!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitofdeepanshu gitofdeepanshu

Labels
enhancement New feature or request project Issue is part of an ongoing project tests If the PR/issue is related to tests, like xcm-simulator tests, rpc-tests etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dinonard @ermalkaleci @shaunxw @gitofdeepanshu