This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: use mcr.microsoft.com for nvidia in mooncake #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Sinz
reviewed
Feb 3, 2023
| @@ -268,7 +268,7 @@ var ( | |||
| KubernetesSpecConfig: KubernetesSpecConfig{ | |||
| KubernetesImageBase: "gcr.azk8s.cn/google_containers/", | |||
| TillerImageBase: "mcr.microsoft.com/", | |||
| NVIDIAImageBase: "dockerhub.azk8s.cn/nvidia/", | |||
| NVIDIAImageBase: "mcr.microsoft.com/", | |||
| AzureCNIImageBase: "mcr.azk8s.cn/containernetworking/", | |||
There was a problem hiding this comment.
What is mcr.azk8s.cn? (Just asking, we have not run into a problem with it.
There was a problem hiding this comment.
I don't know for sure, I would guess it is a (no longer maintained?) mirror of certain mcr.microsoft.com k8s images?
Michael-Sinz
approved these changes
Feb 3, 2023
| @@ -268,7 +268,7 @@ var ( | |||
| KubernetesSpecConfig: KubernetesSpecConfig{ | |||
| KubernetesImageBase: "gcr.azk8s.cn/google_containers/", | |||
| TillerImageBase: "mcr.microsoft.com/", | |||
| NVIDIAImageBase: "dockerhub.azk8s.cn/nvidia/", | |||
| NVIDIAImageBase: "mcr.microsoft.com/", | |||
There was a problem hiding this comment.
This effectively does what we did to our VMs to get things working.
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR updates the mooncake configuration for nvidia driver image pull downloads to use the default
mcr.microsoft.comcontainer image registry.Issue Fixed:
Fixes #5034
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: