Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar sensors "active in HA or not" behavior #153

Closed
rhammen opened this issue Oct 13, 2023 · 3 comments
Closed

Solar sensors "active in HA or not" behavior #153

rhammen opened this issue Oct 13, 2023 · 3 comments

Comments

@rhammen
Copy link
Contributor

rhammen commented Oct 13, 2023

I do not have a solar collector/buffer connected with my heatpump.
In the old integration - after multiple attempts to get it right- , we had the integration code setup such that the solar sensors were not added to the integration in that case --> I liked that :-)

Now, with the new integration, the solar sensors were again present in the integration :-(
I find 2 reasons for that:

  1. The new integration did not use the same (lastest) version of _detect_solar_present() as in the old integration, but an earlier version that does incorrectly detect that solar hardware is present when it isn't.
    --> not a big deal, I can fix that and will create a PR to do that
    I expected that after fixing this, the solar sensors would be automatically removed.
    However this was not the case :-(
    I suspect this related to the 2nd reason:

  2. The new integration seems to have a different approach to adding sensors than the old one:
    Luxtronik now adds all specified entities, unless:

  • current FW version is lower than required by the entity
  • the device does not exist
  • a invisible_if_value value is specified for the entity, which is not (yet?) the case for the solar sensors.
    This means the solar sensors are currently always added, even if a user does not have that hardware.

Is this change on purpose?
I'd rather go back to the old behavior...
Would it be OK if I change the behavior back to the old behavior, e.g. by adding an invisible_if_value property to the solar sensors?

@BenPru
Copy link
Owner

BenPru commented Oct 13, 2023

Yes, good idea.

@rhammen
Copy link
Contributor Author

rhammen commented Oct 15, 2023

Implemented by #154

@rhammen
Copy link
Contributor Author

rhammen commented Oct 18, 2023

Can be closed now with the change implemented in main

@rhammen rhammen closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants