Double code in const.py and xxx.py

[Crashman1983]

Sensors for example are partly doubled within const.py and sensors.py This is error-prone and maintenance-intensive. What's the reason for it?

[BenPru]

Oh yes, the part in const was a try to fulfill the ha core requirements and provide this hacs module as ha module.
In the next time I will try to move the const part in a seperate branch for "future use".

[Crashman1983]

Why did they not accept it? What has to be done to make it an official integration?

[BenPru]

Why did they not accept it? What has to be done to make it an official integration?

See the comments from frenk: Add new integration luxtronik
#59788

• This integration would benefit from using SensorEntityDescriptions instead of passing in all the info.

• I would recommend to rebase this PR onto the latest dev before continuing development on this integration.

• Allow more than one instance of the integration --> Support for multiple Heatpumps #16

• Every pull request can only contain one platform (sensor, binary_, ...)

• Translations should not be an integration task

But the sensor names currently could not translated with home assistant himself!

Many things... :-(

[Kars-de-Jong]

Translation is done through Localise, see Contributing Translation. That's why they shouldn't be included in your PR.

You should create a strings.json file, it contains translations for different things that the integration offers that need to be translated.

But in general in Home Assistant, I believe friendly names for entities are in English, translating them is up to the user. There indeed doesn't seem to be a mechanism in place for translating those.

[BenPru]

Should be fixed in the future with the new integration.