Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Flag Files as solved or not #302

Closed
shadowluigi27 opened this issue Sep 30, 2022 · 2 comments
Closed

[ENHANCEMENT] Flag Files as solved or not #302

shadowluigi27 opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement Improvement to existing feature

Comments

@shadowluigi27
Copy link
Collaborator

Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.

The Batch Grader is extremely slow due to it having to open the files and check each file individually using the check function. We want to improve the speed by making so that the Batch Grader only needs to read the xml flag of a puzzle to determine if it is correct.

Describe the improvement you'd like

Each puzzle file now has a xml flag that is set to false initially, and only when the check proof button is clicked is it ever set to true (if the puzzle is solved). Any changes made immediately sets the flag to false, even if it was true before).

There could also be a indicator in the top left that shows the user if the puzzle is solved or not.

Describe alternatives you've considered

No response

Additional Context

No response

@shadowluigi27 shadowluigi27 added the enhancement Improvement to existing feature label Sep 30, 2022
@dannongw dannongw assigned dannongw and unassigned dannongw Oct 25, 2022
@wei-jun7 wei-jun7 self-assigned this Oct 30, 2022
@wei-jun7
Copy link
Collaborator

It is done using the batch grade to check it is been proof or not.

@charlestian23 charlestian23 added the duplicate This issue or pull request already exists label Jan 17, 2023
@charlestian23
Copy link
Collaborator

Duplicate of #395

@charlestian23 charlestian23 marked this as a duplicate of #395 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement Improvement to existing feature
Projects
None yet
Development

No branches or pull requests

4 participants