Interacting With Previous State Prevents Placement

[MMosley502]

Current Behavior

If a previous state in the tree is accessed after a case rule has been used part or all of the current board will become unmodifiable. Image of unmodifiable state included:

Expected Behavior

The current state should still be modifiable.

Steps to Reproduce

Open a nurikabe a file. Create at least one valid state then use case rule. Once case rule has been used select a state before case rule and change and revert a tile in it. The current state after the case rule will now be unmodifiable.
Attached files with unmodifiable states:
CaseRuleError.zip

[cjreed121]

Looking at your image, it appears you were selected on the blue circle in the TreePanel. If you want to make a change to the board you would do it on an arrow which can be assigned a rule. So this is actually expected behavior that you receive the unmodifiable state message. I'm closing this issue due to this.

[Bram28]

No, this is a real and annoying bug: if you are on the transition you still cannot select squares at times ... and I think it indeed has to do with the case rule. I myself and several students have run into this.

[charlestian23]

A separate occurrence of the same bug:

Current Behavior

Modifying the previous transition of some node renders the node after that node unmodifiable.

Expected Behavior

Modifying the previous transition of some node should not render that node unmodifiable.

Steps to Reproduce

2022-06-06.16-49-09.mp4

unmodifiable_bug.zip

[charlestian23]

I'm going to remove the Nurikabe label since this bug isn't related to something about Nurikabe, and I think it's moreso related how Legup in general deals with users modifying transitions.

[Bram28]

Here is a very easy reproduction. Start with:

Finish the 1 room (it also works if you just make 2 of the 4 squares around it black)

Go back to transition:

Take back some of the changes you made:

Select board state:

... and now you cannot modify the other squares around the 1!

Note: I had thought earlier that it has something to do with the Case rule (that's what Matt thought as well when he created this issue), but it doesn't seem to have anything to do with that. It's what Charles says: something with taking back modifications to squares in an earlier transition ... when you do that, the squares should become modifiable again, but they don't

[Bram28]

And yes, it took me 10 second to reproduce something similar in Light-Up... this is a general LEGUP issue!

[cjreed121]

Thanks for the steps. I was able to reproduce it with @charlestian23 steps. I think I have a fix for it though in #113.