Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact Aggregation by Region #595

Closed
emanuel-schmid opened this issue Dec 1, 2022 · 4 comments
Closed

Impact Aggregation by Region #595

emanuel-schmid opened this issue Dec 1, 2022 · 4 comments

Comments

@emanuel-schmid
Copy link
Collaborator

There should be an easy way to get damages per event and region_id.

There are many ways to implement this, but all of them come with a price on calculation and/or memory. From a discussion on Slack a vague plan emerged to

  • introduce an additional method in Impact that provides this kind of aggregation
  • introduce an additional argument in the ImpactCalc.impact method that indicates how/whether to persist the aggregation result within the Impact object.
@aleeciu
Copy link
Collaborator

aleeciu commented Dec 1, 2022

  • introduce an additional argument in the ImpactCalc.impact method (e.g., at_region_id_event) and the current at_event becomes at_region_id_event.sum(0) or something

@emanuel-schmid
Copy link
Collaborator Author

Er, actually, the case depending replacement of at_event was declined, I'm afraid 😬

@aleeciu
Copy link
Collaborator

aleeciu commented Feb 5, 2023

see proposed addition in #642

@peanutfun
Copy link
Member

Resolved by #642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants