Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMMPatternTracker with downbeats flag #127

Closed
srviest opened this issue Apr 8, 2016 · 6 comments
Closed

GMMPatternTracker with downbeats flag #127

srviest opened this issue Apr 8, 2016 · 6 comments
Labels

Comments

@srviest
Copy link

srviest commented Apr 8, 2016

I tried the GMMPatternTracker executable with --downbeats flag like this:

$ GMMPatternTracker --downbeats single input.wav output.txt

The expected output should be all the downbeats of time instants. However, all the things I got was just 2 float values, is this a bug?

@superbock
Copy link
Collaborator

First of all, please call the program with GMMPatternTracker --downbeats single input.wav -o output.txt, otherwise it does not write the output to output.txt. Note the -o option, which changed some time ago (in commit d575476). If the old calling scheme is still mentioned somewhere, please let me know.

But this is not the problem you are referring to. Unless you provide a link to the used audio file, there is no way to determine if this is the expected output or not. The expected output is a list of timestamps of the downbeats, i.e. only the first column of the lines ending with 1 when being called without the --downbeats option.

You can check if the GMMPatternTracker works properly on your system or not by running the included tests. If you have the sources checked out, just run nosetests in the root directory of the repo. Please note that tests for the programs in /bin were added only recently, so I advise to update madmom first, i.e. do a git pull followed by a git submodule update.

@superbock
Copy link
Collaborator

Just an additional note, please be aware that the GMMPatternTracker uses only rhythmic patterns learnt from Ballroom dance music to detect the beats and downbeats. It might not work well for other type of music.

P.S. stay tuned for a general purpose downbeat tracker I will add soon

@srviest
Copy link
Author

srviest commented Apr 8, 2016

Opps, sorry for the typo.
I called theGMMPatternTrackerby GMMPatternTracker single input.wav -o output.txt.
And it returned output like:
0.320 1
1.040 2
1.760 3
2.480 4
3.200 1
3.900 2
4.600 3
5.300 4
....and so on.

But when I called the program with --downbeats, it just returned:
0.320
1.000

@superbock
Copy link
Collaborator

This is clearly a bug, I'll look into it. Thanks for reporting!

@superbock superbock added the bug label Apr 8, 2016
@superbock
Copy link
Collaborator

Should be fixed in the fix_downbeat_output branch (PR #128). The issue will be closed when I merge this, please feel free to reopen the issue if it does not solve your problem.

@superbock
Copy link
Collaborator

FYI: I merged the RNN/DBN downbeat tracking stuff mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants