Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI not detecting failed doc builds #1087

Closed
mramato opened this issue Aug 29, 2013 · 2 comments · Fixed by #1088
Closed

Travis CI not detecting failed doc builds #1087

mramato opened this issue Aug 29, 2013 · 2 comments · Fixed by #1088
Labels
category - doc category - tooling type - bug

Comments

@mramato
Copy link
Contributor

mramato commented Aug 29, 2013

Travis is reporting branches okay even though master (and any up to date branches) have a broken doc build. Check out this log: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/10714036 from #1080 (now fixed)

The generateDocumentation step threw an exception but Travis claimed it passed.

Are we searching for key words in the output? What causes it to be a failure?

CC @shunter @cmorse
@shunter
Copy link
Contributor

shunter commented Aug 29, 2013

Turns out the default value for failonerror on the java ant task is false, which is pretty stupid. I'll open a pull request and we'll see if the travis build fails.

@shunter shunter mentioned this issue Aug 29, 2013
Merged
@cmorse
Copy link
Contributor

cmorse commented Aug 29, 2013

@shunter Wow, failonerror defaults to false! What were they thinking!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - doc category - tooling type - bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail the build when JSDoc fails. CesiumGS/cesium
3 participants
@shunter @cmorse @mramato