Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development-only examples on cesiumjs.org #3306

Closed
mramato opened this issue Dec 8, 2015 · 6 comments
Closed

Development-only examples on cesiumjs.org #3306

mramato opened this issue Dec 8, 2015 · 6 comments

Comments

@mramato
Copy link
Contributor

mramato commented Dec 8, 2015

The current deployed copy of Sandcastle, http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html, is showing the Development category and demos. I'm not sure if this has always been the case or something that happened last release, but these demos are not intended for end user consumption and shouldn't be on the website.

FYI, the old release links don't have this problem because they use the zip content and not the cesiumjs.org branch.

@AmayAgrawal
Copy link
Contributor

So sir we have to just remove the whole thing (i.e. Development category).Can I work on it??

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 7, 2016

I thought there was another issue for this, but I am still in support of including the Development examples, especially now for CI since, for example, we can't test the hosted branch for #3819.

@mramato
Copy link
Contributor Author

mramato commented Apr 7, 2016

You can still access those examples, they just aren't in the gallery (we could also change this for CI builds): http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/shadows-commands/Apps/Sandcastle/index.html?src=development/Shadows.html&label=Showcases

I would rather see us "promote" relevant examples (perhaps a Primitives label) instead of just exposing all developer examples on the website. Developer examples are largely unmaintained and anything on the site should be curated enough that it gets tested with each release.

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 11, 2016

All the development examples work AFAIK. I test them when I do a release. I'm OK with positioning them however you want, but hiding them is clearly not working for us and users. Given everything we are working on, what do you realistically want to see happen in the short-term? Just show them by default for CI?

@hpinkos
Copy link
Contributor

hpinkos commented Apr 11, 2016

There have been multiple people on the forum asking where the development tab went. It's nice to have it on the website because every now and again I need to link to an example for a question someone has on the forum.

I'm okay with compromising and keeping the less polished examples off of the website. But I agree with @pjcozzi, I wouldn't say they're unmaintained. Most of those demos are in good shape and they're useful to people.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 20, 2016

I haven't seen anyone in the forum mention this in a really long time, so I'm going to close this issue

@hpinkos hpinkos closed this as completed Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants