Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if EllipsoidGeometry stackPartitions or slicePartitions are non-integer #5260

Closed
shunter opened this issue May 1, 2017 · 0 comments
Closed

Crash if EllipsoidGeometry stackPartitions or slicePartitions are non-integer #5260

shunter opened this issue May 1, 2017 · 0 comments
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@shunter
Copy link
Contributor

shunter commented May 1, 2017

For somewhat obvious reasons, these parameters must be integers (they get used to allocate arrays, for example). Currently the doc doesn't indicate this. The code should validate this as well (or potentially we could just truncate the input).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shunter @pjcozzi @hpinkos