Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pipeline extras for glTF #5776

Closed
hpinkos opened this issue Aug 24, 2017 · 2 comments · Fixed by #6805
Closed

Remove pipeline extras for glTF #5776

hpinkos opened this issue Aug 24, 2017 · 2 comments · Fixed by #6805
Labels
cleanup priority - high

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Aug 24, 2017

This change was made to fix a caching bug: #5728

But as a result, extras: {_pipeline: {....}} is added everywhere in the Model.glTF object. This has to significantly bloat the size of the gltF in memory.
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 18, 2018

@lilleyse is this still an issue in the latest gltf-pipeline?

@lilleyse
Copy link
Contributor

Now extras are only added to buffers, images, and shaders, so it has improved. Still it would be better to remove them completely. @ggetz can you look at this as part of Cesium's gltf-pipeline upgrade?

@lilleyse lilleyse mentioned this issue Jun 18, 2018
Closed
6 tasks
@ggetz ggetz mentioned this issue Jul 16, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup priority - high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gltf Pipeline and support KHR_techniques_webgl and KHR_blend CesiumGS/cesium
3 participants
@pjcozzi @lilleyse @hpinkos