Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery stops loading when changing terrain in request render mode #6193

Closed
hpinkos opened this issue Feb 7, 2018 · 13 comments
Closed

Imagery stops loading when changing terrain in request render mode #6193

hpinkos opened this issue Feb 7, 2018 · 13 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Feb 7, 2018

image

Easiest way to reproduce

  • Zoom in close to the ground and hit the Disable terrain button until the imagery stops loading in (usually 2-5 clicks)
  • Hit the Enable terrain button
  • Now the imagery never loads in, even after the camera moves

I wasn't able to reproduce this when requestRenderMode: false, so it seems to be related to those changes.
It seems like it might be related to changing the terrain before all imagery tiles are loaded, but I'm not sure.

var viewer = new Cesium.Viewer('cesiumContainer', {
    requestRenderMode : true,
    animation: false,
    timeline: false
});

var cesiumTerrainProviderMeshes = new Cesium.CesiumTerrainProvider({
    url : 'https://assets.agi.com/stk-terrain/v1/tilesets/world/tiles',
    requestWaterMask : true,
    requestVertexNormals : true
});
viewer.terrainProvider = cesiumTerrainProviderMeshes;

Sandcastle.addToolbarButton('Enable terrain', function() {
    viewer.terrainProvider = new Cesium.CesiumTerrainProvider({
        url : 'https://assets.agi.com/stk-terrain/v1/tilesets/world/tiles',
        requestWaterMask : true,
        requestVertexNormals : true
    });
    viewer.scene.requestRender();
});

Sandcastle.addToolbarButton('Disable terrain', function() {
    viewer.terrainProvider = new Cesium.EllipsoidTerrainProvider();
    viewer.scene.requestRender();
});
@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 7, 2018

@ggetz any ideas here? Let me know if you have trouble reproducing it

@ggetz
Copy link
Contributor

ggetz commented Feb 7, 2018

@hpinkos I can reproduce, but I need to take a closer look to see what's causing this.

@hpinkos
Copy link
Contributor Author

hpinkos commented Mar 1, 2018

@ggetz while it's not as bad, I'm definitely still seeing problems with this. Please look into it further for next release. Thanks!

@mramato
Copy link
Contributor

mramato commented Mar 21, 2018

@hpinkos can you list steps to still reproduce this. I know we fixed the initial issue, but we should really fix this completely as reliability is really important when using requestRender.

@hpinkos
Copy link
Contributor Author

hpinkos commented Mar 21, 2018

@mramato I'll have to trace what's going on in composer to figure out a way to reliably reproduce it. It's really easy to reproduce in that application but difficult to reproduce with the sandcastle example I put together.

@lilleyse
Copy link
Contributor

lilleyse commented Apr 2, 2018

This likely won't make it into 1.44 but I've leave the next release label.

@mramato
Copy link
Contributor

mramato commented Apr 26, 2018

@hpinkos, @ggetz is this still planned for May 1st? If not, we really need to fix it for June 1st.

@hpinkos
Copy link
Contributor Author

hpinkos commented Apr 26, 2018

Sorry, didn't have time to look into it this month

@ggetz
Copy link
Contributor

ggetz commented Jun 1, 2018

I think this will need to be bumped to next month, I need the steps to reproduce this.

@ggetz
Copy link
Contributor

ggetz commented Jun 21, 2018

@hpinkos Could you take a look at providing steps to reproduce?

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 21, 2018

@ggetz yes, this is next on my list as soon as I wrap up the few features I'm working on

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 25, 2018

Probably not going to have a chance to look at this for the July release, but I'll have a reproducible example ASAP so we can fix this for the August release

@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 3, 2018

Well, I actually can't reproduce this anymore. @mramato reopen this if you still see it

@hpinkos hpinkos closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants