Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesium no longer adds a default material for gltf 2.0 as needed #6891

Closed
likangning93 opened this issue Aug 7, 2018 · 3 comments · Fixed by #6906
Closed

Cesium no longer adds a default material for gltf 2.0 as needed #6891

likangning93 opened this issue Aug 7, 2018 · 3 comments · Fixed by #6906
Labels
priority - next release type - bug

Comments

@likangning93
Copy link
Contributor

likangning93 commented Aug 7, 2018 •
edited
Loading

See attached. This is a gltf 2.0 containing a primitive that doesn't have an assigned material.
Cesium 1.47 handled this according to spec and assigned a default material, but 1.48 crashes instead.

CUBE.zip
@likangning93
Copy link
Contributor Author

Git bisect points to 7e12268

@lilleyse
Copy link
Contributor

lilleyse commented Aug 7, 2018

Yeah this is my fault...

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/ThirdParty/GltfPipeline/addDefaults.js#L512-L515

I added that to stop it from generating 1.0 shaders for glTF 2.0 models but forgot that 2.0 primitives need default materials too. I'll open a fix.

@lilleyse lilleyse mentioned this issue Aug 10, 2018
Merged
@ggetz ggetz closed this as completed Aug 16, 2018
@lilleyse lilleyse reopened this Aug 20, 2018
@lilleyse
Copy link
Contributor

Reopened until #6805 is merged

@lilleyse lilleyse mentioned this issue Aug 20, 2018
Closed
@emackey emackey mentioned this issue Aug 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority - next release type - bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix model crash by adding default pbr material CesiumGS/cesium
3 participants
@lilleyse @ggetz @likangning93