Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolutionScale related lighting issue #8358

Closed
vinstics opened this issue Nov 5, 2019 · 3 comments · Fixed by #8351
Closed

resolutionScale related lighting issue #8358

vinstics opened this issue Nov 5, 2019 · 3 comments · Fixed by #8351

Comments

@vinstics
Copy link

vinstics commented Nov 5, 2019

Sandcastle example: sandcastle

Browser: Chrome 78

Operating System: Windows 10 1903

Monitor: 14 inch 3200x1800 250% zoom

Browser Zoom: 100%

Set "viewer.scene.globe.enableLighting = true" can replicate the problem. Happens only when devicePixelRatio not equals 1.
And, images near the pole seem to be strange.

image

image

@OmarShehata
Copy link
Contributor

@vinstics this is a known issue. We have a fix for it here: #8351

In the mean time you can fix it by setting:

viewer.resolutionScale = 1.0 / window.devicePixelRatio;

This brings the resolutionScale back to the old behavior as of 1.61 (see the explanation of this change here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CHANGES.md#additions-tada-2).

@vinstics
Copy link
Author

vinstics commented Nov 6, 2019

@OmarShehata Thanks a lot. I'll turn off lighting and wait for the fix since I have to render model at native device resolution. By the way how about the image near the pole, is it normal?

@OmarShehata
Copy link
Contributor

@vinstics I believe the poles look like that when the imagery layer does not cover the poles, and so CesiumJS will stretch the pixels to fill the gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants