Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate potential issues with duplicate polyline vertices #898

Closed
mramato opened this issue Jun 25, 2013 · 5 comments
Closed

Investigate potential issues with duplicate polyline vertices #898

mramato opened this issue Jun 25, 2013 · 5 comments

Comments

@mramato
Copy link
Contributor

mramato commented Jun 25, 2013

See this thread, which applies to Linux.

On Windows there seem to be some minor artifacts as well, but the lines are clearly drawn.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 30, 2013

Also see this thread for the wall geometry.

These should be calling PolylinePipeline.removeDuplicates.

@mramato
Copy link
Contributor Author

mramato commented Sep 14, 2013

Is this fixed now? I seem to remember some recent pull request in regards to removing duplicates. @bagnell?

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 26, 2013

Yes @bagnell's change should have fixed this, but I'm having a hard time finding the pull request.

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 8, 2014

OK to close this?

@mramato
Copy link
Contributor Author

mramato commented Apr 25, 2014

I was ready to close this but a quick search of the code seems to indicate that we aren't removing duplicates anywhere in Polyline.js or PolylineColleciton.js. I'm also not sure what the performance implications of doing so would be. We may just want to close this anyway until it becomes an issue again @bagnell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants