Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No filter issue #6

Open
yacari opened this issue Dec 17, 2020 · 1 comment
Open

No filter issue #6

yacari opened this issue Dec 17, 2020 · 1 comment

Comments

@yacari
Copy link

yacari commented Dec 17, 2020

Hello,

First, thanks a lot for the work !
I am just here to present an issue I fixed for your component :
In the Apex controller line 57 your checking if the filter is null, in my case I did not set any filter in the component and it was considering the filter as an empty string, so not null.
Leading to a wrong query with AND () inside.
I just change the check by : if (Filter != '')

Thanks for this component ;)

@christiancoleman
Copy link

@yacari I appreciate you calling this out. I didn't have a filter either and ran into search errors. I used the below for my quick fix:

if (String.isNotBlank(Filter) || String.isNotEmpty(Filter)) {
        sQuery += ' AND (' + Filter + ')';
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants