From c8956573106ee48219e03242046551da03a529c9 Mon Sep 17 00:00:00 2001 From: mrT23 Date: Sun, 29 Oct 2023 17:59:46 +0200 Subject: [PATCH 1/2] fixed review --- pr_agent/algo/utils.py | 3 ++- pr_agent/tools/pr_reviewer.py | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/pr_agent/algo/utils.py b/pr_agent/algo/utils.py index 423771a3d..304c2200e 100644 --- a/pr_agent/algo/utils.py +++ b/pr_agent/algo/utils.py @@ -101,7 +101,8 @@ def parse_code_suggestion(code_suggestions: dict, gfm_supported: bool=True) -> s markdown_text += f" **{sub_key}:** {sub_value}\n" if not gfm_supported: if "relevant line" not in sub_key.lower(): # nicer presentation - markdown_text = markdown_text.rstrip('\n') + "\\\n" + # markdown_text = markdown_text.rstrip('\n') + "\\\n" # works for gitlab + markdown_text = markdown_text.rstrip('\n') + " \n" # works for gitlab and bitbucker markdown_text += "\n" return markdown_text diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py index be938b4a3..d46f24e3e 100644 --- a/pr_agent/tools/pr_reviewer.py +++ b/pr_agent/tools/pr_reviewer.py @@ -116,10 +116,11 @@ async def run(self) -> None: if get_settings().config.publish_output: get_logger().info('Pushing PR review...') - previous_review_comment = self._get_previous_review_comment() self.git_provider.publish_comment(pr_comment) self.git_provider.remove_initial_comment() - self._remove_previous_review_comment(previous_review_comment) + previous_review_comment = self._get_previous_review_comment() + if previous_review_comment: + self._remove_previous_review_comment(previous_review_comment) if get_settings().pr_reviewer.inline_code_comments: get_logger().info('Pushing inline code comments...') self._publish_inline_code_comments() From 71da20ea7e1be6ccfdec4a2205d61fe294505d9a Mon Sep 17 00:00:00 2001 From: mrT23 Date: Sun, 29 Oct 2023 18:01:50 +0200 Subject: [PATCH 2/2] better link --- RELEASE_NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 082c05833..a3ed836db 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -10,7 +10,7 @@ - New tool - [generate_labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/GENERATE_CUSTOM_LABELS.md) - New ability to use [customize labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/GENERATE_CUSTOM_LABELS.md#how-to-enable-custom-labels) on the `review` and `describe` tools. - GitHub Action: Can now use a `.pr_agent.toml` file to control configuration parameters (see [Usage Guide](./Usage.md#working-with-github-action)). -- GitHub App: Added ability to trigger tools on push events (see [link](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L91)) +- GitHub App: Added ability to trigger tools on [push events](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools-for-new-code-pr-push) - Support custom domain URLs for azure devops integration (see [link](https://github.com/Codium-ai/pr-agent/pull/381)). - PR Description default mode is now in [bullet points](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L35).