Screenshots of individual elements of the page #44

subiron · 2017-01-13T14:40:51Z

added ability to take screenshots of parts of the page by using css or xpath element selectors

Please do not merge yet!
(Base branch is set to "modifiers_enhancements" for clear diff until modifiers_enhancements be merged into master branch)

I hereby agree to the terms of the AET Contributor License Agreement.

Update Hide Modifier with find elements by css selector #15

…attributes

…y using css or xpath element selectors

malaskowski · 2017-01-16T07:44:25Z

core/jobs/src/main/java/com/cognifide/aet/job/common/collectors/screen/ScreenCollector.java

-import org.openqa.selenium.TakesScreenshot;
-import org.openqa.selenium.WebDriver;
-import org.openqa.selenium.WebDriverException;
+import org.openqa.selenium.*;


Please don't use * imports.

malaskowski · 2017-01-16T07:46:20Z

core/jobs/src/main/java/com/cognifide/aet/job/common/collectors/screen/ScreenCollector.java

@@ -22,76 +22,109 @@
 import com.cognifide.aet.job.api.collector.CollectorProperties;


Please check your formatter settings and make sure you use Google Formatter.

# Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/w3chtml5/W3cHtml5ComparatorJob.java

…ements' into screen_parts # Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/WebElementsLocatorParams.java

…enium

malaskowski

Nice work and very valuable feature!

malaskowski · 2017-01-20T08:42:47Z

core/jobs/src/main/java/com/cognifide/aet/job/common/collectors/screen/ScreenCollector.java

@@ -83,15 +97,62 @@ private boolean isPatternAndResultMD5Identical(byte[] screenshot) {

  @Override
  public void setParameters(Map<String, String> params) throws ParametersException {
-    //No parameters here
+    if (StringUtils.isNotBlank(params.get(XPATH_PARAM)) || StringUtils


Maybe we could move setting parameters from WebElementsLocatorParams to some method in WebElementsLocatorParams?

it is, but this is extra check for screen collector as both of those params are optional.

malaskowski · 2017-01-20T08:50:43Z

core/jobs/src/main/java/com/cognifide/aet/job/common/collectors/screen/ScreenCollector.java

    }
  }

+  private byte[] bufferedImageToByteArray(BufferedImage bufferedImage) throws ProcessingException {
+    ByteArrayOutputStream temporaryStream = new ByteArrayOutputStream();
+    try {


You may get benefit from Closable interface that ByteArrayOutputStream implements:

try (ByteArrayOutputStream temporaryStream = new ByteArrayOutputStream()){ ImageIO.write(bufferedImage, PNG_FORMAT, temporaryStream); temporaryStream.flush(); return temporaryStream.toByteArray(); } catch (IOException e) { throw new ProcessingException("Unable to convert screenshot part to byte Array", e); }

I always forget about that

malaskowski · 2017-01-20T08:51:57Z

documentation/src/main/wiki/ScreenCollector.md

+| --------- | ----- | ----------- | --------- |
+| `xpath` | xpath_to_element | Xpath to element(s) | optional (either xpath or css) |
+| `css` | css_selector_to_element | css selector to element(s)| optional (either xpath or css) |
+| `timeout` | 1000ms | The timeout for the element to appear, in milliseconds. The max value of this parameter is 15000 milliseconds (15 seconds). | no (default will be used) |


It looks that timeout parameter is used only when one of selectors is used. It should be mentioned here unless its possible to update the code (which would be much more awesome!).

you mean some kind if warning message when timeout param is provided but neither xpath or css ?

I'd rather thought about mentioning at documentation, that timeout parameter is applicable only when taking a screenshot of a page element. It does not work in fullScreen mode.
But I would be much more happier if timeout would also work in fullScreen mode and there would be no need to change docs then.

But I would be much more happier if timeout would also work in fullScreen mode and there would be no need to change docs then.

I have no idea how to (for what purpose) use timeout param when taking fullscreen-shot
(we have sleep modifier for that)
imo just update doc, what do you think ?

malaskowski · 2017-01-20T08:52:24Z

integration-tests/test-suite/partials/layout.xml

@@ -118,5 +118,19 @@
 			<url href="comparators/layout/failed.jsp" />
 		</urls>
 	</test>
+
+	<test name="comparator-Layout-Partial-SUCCESS">


Please provide one more test for xpath selector.

malaskowski

I've pushed small improvements for this CR.

update tests values

subiron added 9 commits January 3, 2017 14:06

Update Click Modifier with find elements by css selector #14

68a7df1

Update Hide Modifier with find elements by css selector #15

AETS-166 feature: replacing text inside tags (innerHtml) and in tags …

801a2f0

…attributes

AETS-166 added missing license

1dabb81

ZGCQ-7511 fixed documentation

25dccc3

ZGCQ-7511 fixes, cr, typos

9dbb988

ZGCQ-7511 cr fixes

3f3b61f

ZGCQ-7511 cr fixes

6b53a5d

ZGCQ-7511 cr fixes

91a725e

screen_parts added ability to take screenshots of parts of the page b…

7e83769

…y using css or xpath element selectors

malaskowski reviewed Jan 16, 2017

View reviewed changes

wiiitek and others added 8 commits January 16, 2017 23:49

Update ReplaceTextModifier.md

216d5dd

Update HideModifier.md

3af8f83

ZGCQ-7582 cr fixes

5d10490

Merge branch 'master' into feature/modifiers_enhancements

941ced8

# Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/w3chtml5/W3cHtml5ComparatorJob.java

Merge remote-tracking branch 'remotes/origin/feature/modifiers_enhanc…

74d1e60

…ements' into screen_parts # Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/WebElementsLocatorParams.java

Merge remote-tracking branch 'remotes/origin/feature/modifiers_enhanc…

90e9c05

…ements' into screen_parts # Conflicts: # core/jobs/src/main/java/com/cognifide/aet/job/common/modifiers/WebElementsLocatorParams.java

removed one test due to issue with mocking some internal parts of sel…

360801c

…enium

Merge branch 'feature/modifiers_enhancements' into screen_parts

a821633

subiron changed the base branch from master to feature/modifiers_enhancements January 19, 2017 12:06

subiron added 2 commits January 19, 2017 13:07

Code reformat

fcbf149

Code reformat

8f353b1

subiron changed the base branch from feature/modifiers_enhancements to master January 19, 2017 12:11

subiron changed the base branch from master to feature/modifiers_enhancements January 19, 2017 12:11

subiron added 3 commits January 19, 2017 13:15

Merge branch 'feature/modifiers_enhancements' into screen_parts

eb13729

small refactor

98a1ca3

Merge remote-tracking branch 'origin/screen_parts' into screen_parts

d0b8f5c

subiron self-assigned this Jan 19, 2017

small refactor

983b9d1

subiron changed the title ~~Screen parts~~ Screenshots of indyvidual elements of the page Jan 19, 2017

subiron changed the title ~~Screenshots of indyvidual elements of the page~~ Screenshots of individual elements of the page Jan 19, 2017

malaskowski suggested changes Jan 20, 2017

View reviewed changes

subiron and others added 2 commits January 20, 2017 12:46

cr fixes(improve docs, added extra test case in sanity)

35e544f

CR fixes & improvements

90602f4

malaskowski approved these changes Jan 20, 2017

View reviewed changes

subiron added 4 commits January 20, 2017 14:00

revert some parts of previous commit

dcc98db

update tests values

fix after merge

4832103

Merge branch 'feature/modifiers_enhancements' into screen_parts

31d8a55

update test values

e1551b9

subiron changed the base branch from feature/modifiers_enhancements to master January 20, 2017 21:01

merge master

d65d5fe

subiron merged commit e7dfa3a into master Jan 20, 2017

malaskowski deleted the screen_parts branch January 20, 2017 23:48

subiron mentioned this pull request Feb 24, 2017

Update AET version in vagrantfile and update changelog #63

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Screenshots of individual elements of the page #44

Screenshots of individual elements of the page #44

subiron commented Jan 13, 2017 •

edited

Loading

malaskowski Jan 16, 2017

malaskowski Jan 16, 2017

subiron Jan 19, 2017

malaskowski left a comment

malaskowski Jan 20, 2017

subiron Jan 20, 2017

malaskowski Jan 20, 2017

subiron Jan 20, 2017

malaskowski Jan 20, 2017

subiron Jan 20, 2017

malaskowski Jan 20, 2017

subiron Jan 20, 2017

malaskowski Jan 20, 2017

malaskowski left a comment

		@@ -22,76 +22,109 @@
		import com.cognifide.aet.job.api.collector.CollectorProperties;

Screenshots of individual elements of the page #44

Screenshots of individual elements of the page #44

Conversation

subiron commented Jan 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malaskowski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malaskowski left a comment

Choose a reason for hiding this comment

subiron commented Jan 13, 2017 •

edited

Loading