Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collectors and comparators configured by single config number #451

Merged
merged 17 commits into from
Dec 21, 2018
Merged

Collectors and comparators configured by single config number #451

merged 17 commits into from
Dec 21, 2018

Conversation

malaskowski
Copy link
Contributor

@malaskowski malaskowski commented Dec 10, 2018 •
edited
Loading

Description

This is first step of unifying AET testing throughput #361

Motivation and Context

Now it is easier to configure number of collectors and comparatorors in the system.
Also, it is now possible to override those values via env variables.

Upgrade notes (if appropriate)

AET admins:
Remove all CollectorMessageListenerImpl and ComparatorMessageListenerImpl config files.
Create com.cognifide.aet.worker.listeners.WorkersListenersService.cfg and configure proper number of collectors and comparators there.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@wiiitek wiiitek mentioned this pull request Dec 11, 2018
Merged
5 tasks
wiiitek
wiiitek approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@wiiitek wiiitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes! Happy to see that we are getting closer to Docker..
Some proposed changes for this PR are in #452

@malaskowski malaskowski added the QA Required Requires manual tests, possible regression or impact on existing features. label Dec 12, 2018
@Slasheruus
Copy link
Contributor

Tested

@tkaik tkaik merged commit 8deb8c2 into master Dec 21, 2018
@tMaxx tMaxx deleted the feature/collectors-and-comparators-configured-by-single-config-number branch August 6, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiiitek wiiitek wiiitek approved these changes

@tkaik tkaik tkaik approved these changes

@plutasnyy plutasnyy Awaiting requested review from plutasnyy

Assignees
No one assigned
Labels
QA Required Requires manual tests, possible regression or impact on existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@malaskowski @Slasheruus @wiiitek @tkaik @Skejven