feat: partially implement EC_DATA #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delehef
requested review from
letypequividelespoubelles,
powerslider,
OlivierBBB and
lorenzogentile404
and removed request for
powerslider
Closed
powerslider
reviewed
Dec 7, 2023
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcData.java
Show resolved
Hide resolved
powerslider
reviewed
Dec 7, 2023
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcDataOperation.java
Show resolved
Hide resolved
powerslider
reviewed
Dec 7, 2023
arithmetization/src/test/java/net/consensys/linea/zktracer/module/EcDataTest.java
Show resolved
Hide resolved
powerslider
reviewed
Dec 7, 2023
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcDataOperation.java
Outdated
Show resolved
Hide resolved
lorenzogentile404
approved these changes
Dec 7, 2023
powerslider
approved these changes
Dec 7, 2023
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcData.java
Outdated
Show resolved
Hide resolved
letypequividelespoubelles
approved these changes
Dec 8, 2023
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcData.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcDataOperation.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcDataOperation.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/ec_data/EcDataOperation.java
Show resolved
Hide resolved
delehef
force-pushed
the
feat/issue-123/ec-data
branch
from
9ea0220
to
387a41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the EC_DATA module up to the tracing.
Working: line counting
Not (yet) working: tracing, as we miss a BN256 library for now