Check upfront profitability + Unprofitable txs cache and retry limit #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
unprofitable-txs-cache
branch
6 times, most recently
from
acaa580
to
e67d089
Compare
|
LGTM so far |
fab-10
force-pushed
the
unprofitable-txs-cache
branch
5 times, most recently
from
c74ac3e
to
46dab38
Compare
jonesho
reviewed
Jan 26, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Outdated
Show resolved
Hide resolved
...a/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelectorTest.java
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
unprofitable-txs-cache
branch
from
758ecf4
to
3256771
Compare
Filter94
reviewed
Jan 30, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
Filter94
reviewed
Jan 30, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
Filter94
approved these changes
Jan 30, 2024
macfarla
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we want to mitigate the impact of unprofitable txs on the block creation process.
Fixes #564
gasLimit, this way we can filter txs that are upfront unprofitable without never processing them. If this check is not passed then the newTX_UNPROFITABLE_UPFRONTcode is returned.TX_UNPROFITABLE_RETRY_LIMITcode is returned.TX_UNPROFITABLE_MIN_GAS_PRICE_INCREASEDcode is returnedTwo new options:
plugin-linea-unprofitable-cache-sizemax number of unprofitable txs we keep track of. Default 100_000.plugin-linea-unprofitable-retry-limithow many cached unprofitable txs could be retried every block, Default 10.