Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest value is not copied to external source lookup tab #3295

Open
jensvannerum opened this issue Sep 4, 2024 · 0 comments · May be fixed by #3296
Open

Latest value is not copied to external source lookup tab #3295

jensvannerum opened this issue Sep 4, 2024 · 0 comments · May be fixed by #3296
Assignees
@jensvannerum
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: Atmire Atmire team is working on this issue & will contribute back e/1 Estimate in hours port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release

Comments

@jensvannerum
Copy link
Contributor

Describe the bug

In any place where the DsDynamicLookupRelationModalComponent is used (e.g auhtor lookup during submission) the value selected for lookup is correctly filled in as a query in the external sources tab. However, when closing the modal and opening it for another author, the old author's name is still filled in as query instead of the new one.

To Reproduce

video example

  • Start submission and add two plain text authors
  • select the lookup icon on the first author, navigate to the external source tab and verify the author name is filled in as query
  • close the modal
  • select the lookup icon on the second author, navigate to the external source tab and verify the first author name is still filled in

Expected behavior

We would always expect the value of the lookup to be filled in as query
@jensvannerum jensvannerum added bug needs triage New issue needs triage and/or scheduling labels Sep 4, 2024
@jensvannerum jensvannerum self-assigned this Sep 4, 2024
@jensvannerum jensvannerum added e/1 Estimate in hours claimed: Atmire Atmire team is working on this issue & will contribute back port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Sep 4, 2024
@jensvannerum jensvannerum linked a pull request Sep 4, 2024 that will close this issue
Open
12 tasks
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensvannerum jensvannerum

Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: Atmire Atmire team is working on this issue & will contribute back e/1 Estimate in hours port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
DSpace 8.x and 7.6.x Maintenance
Status: 🏗 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass query to external search tab bugfix atmire/dspace-angular
2 participants
@tdonohue @jensvannerum