Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bound memory #9

Closed
Duccan opened this issue Sep 20, 2018 · 1 comment
Closed

Out of bound memory #9

Duccan opened this issue Sep 20, 2018 · 1 comment
Labels
Milestone

Comments

@Duccan
Copy link

Duccan commented Sep 20, 2018

In DMXUSB.cpp line 93, you are writing to your buffer out of range. When _index is zero, your writing to _buffer at index (unsigned int) 0 - (unsigned int) 1 which equals to a max value of unsigned int 65535 (depends on target). If you want to omit the first bit, build a check for it to skip it.

@DaAwesomeP
Copy link
Owner

Hi @Duccan,
I'm surprised I didn't catch this myself! If you'd like to submit a pull and can test it on your own hardware, that is very welcome. I can try to release a fix in the next week or so.

@DaAwesomeP DaAwesomeP added the bug label Sep 25, 2018
@DaAwesomeP DaAwesomeP added this to the v0.0.4 milestone Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants