Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrantfile icon looks crunchy #381

Closed
monkpit opened this issue Jun 10, 2016 · 5 comments
Closed

Vagrantfile icon looks crunchy #381

monkpit opened this issue Jun 10, 2016 · 5 comments
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.

Comments

@monkpit
Copy link

monkpit commented Jun 10, 2016

First of all, thanks for making this package! I really love having these extra icons - it makes identifying items my project tree take literally no time at all.

Lately I've been working on a project that involves having a Vagrantfile in the root directory (so I'm always looking at it ;) )

I've opened up the font file itself and I can see how the Vagrantfile icon matches the vibe of the Vagrant logo created by Hashicorp. However, when the icons are shown at a smaller scale (font size 10-16 on a 27" Thunderbolt screen at 2560x1440) the icon kinda looks like it got chewed on a little bit.

screen shot 2016-06-10 at 8 40 35 am

I'm not sure if there's a way you could handle this. Maybe changing the icon at lower font sizes to just be a plain stylized V character.

Anyways, thanks again for making this package and updating it so regularly! Cheers.

@Alhadis
Copy link
Member

Alhadis commented Jun 10, 2016

I'm afraid there's not much that can be done about the Vagrantfile character... it was a difficult logo to create an icon out of (and it looked much worse when I tried leaving the holes in...). I suppose I could add a variant where the edges aren't chewed... would that help?

(Some logos are just a plain pain-in-the-arse to work with...)

Also, thanks for the kind words! =)

@monkpit
Copy link
Author

monkpit commented Jun 10, 2016

That's kinda what I was thinking as well, just create a version that looks like a solid V without any munchy parts. Thanks again :)

@Alhadis
Copy link
Member

Alhadis commented Jun 11, 2016

Actually, screw it, the icon looks better without the erosion anyway. It's hardly recognisable at such a small size, so, you're right, it's better this way. =)

Done.

@monkpit
Copy link
Author

monkpit commented Jun 27, 2016

@Alhadis you rock - just FYI.

@Alhadis
Copy link
Member

Alhadis commented Jun 27, 2016

<3 Nawh, thanks mate.

@Alhadis Alhadis added enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font. labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.
Projects
None yet
Development

No branches or pull requests

2 participants