Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node modules icon is colored even when on changes is checked #390

Closed
michael-yx-wu opened this issue Jun 16, 2016 · 2 comments
Closed

Node modules icon is colored even when on changes is checked #390

michael-yx-wu opened this issue Jun 16, 2016 · 2 comments
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.

Comments

@michael-yx-wu
Copy link

screen shot 2016-06-16 at 11 57 12 am

I've made no changes to node_modules but the icon is still colored even though on changes is selected in settings.
@Alhadis
Copy link
Member

Alhadis commented Jun 16, 2016

Ah! I think only files are being targeted by that rule. Until recently, there weren't any folder icons that used colour, so it never came to mind.

Will fix.

@Alhadis
Copy link
Member

Alhadis commented Jun 16, 2016

Fixed, thanks for pointing that out! =)

@Alhadis Alhadis added the bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alhadis @michael-yx-wu