Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveContent not stable #165

Closed
ice1e0 opened this issue Jun 12, 2020 · 5 comments
Closed

ActiveContent not stable #165

ice1e0 opened this issue Jun 12, 2020 · 5 comments

Comments

@ice1e0
Copy link

ice1e0 commented Jun 12, 2020

When I bind to ActiveContent, it seems like something is not stable at some circumstances:

I have the following layout:
image

When I add an page to 'DocumentPages', I get three times an update of 'ActiveContent' that the added page is now my new page. (This is not an huge issue; it's just a bit confusing and I had this already using the Xceed AvalonDock in Version 3.5.7).

The issue comes in two other steps:

  1. When I click e.g. a bit besides the tab-header of the document page, the 'ActiveContent' is set to 'null' (which is not true, since the document page is still shown as active!) --> this issue is not present in the 3.5.7 version.
  2. When I close the page, I would expect the 'ActiveContent' be set to 'null', but this does not happen (this issue is present in 3.5.7 as well).

Maybe I misunderstand the 'ActiveContent' property. What I really need is a property giving me the current active document of the 'DocumentPages' (DocumentsSource); so, something like 'SelectedDocument' would just make it for me.

Btw; I am using Dirkster.AvalonDock in Version 4.20.0 in a .NET Core 3.1 app, recently upgraded from an old 3.5.7 version ...

@LyonJack
Copy link
Contributor

LyonJack commented Jul 2, 2020

Fixed in my pull request @Dirkster99

@Dirkster99
Copy link
Owner

@ice1e0 can you please confirm whether this issue is solved with the current master branch?

@LyonJack
Copy link
Contributor

LyonJack commented Jul 5, 2020

I find that in the code gives any changed abount ActiveContect,I add more judgment to reslove that
@ice1e0 have a test if this work well

@ice1e0
Copy link
Author

ice1e0 commented Jul 6, 2020

👍 works

@Dirkster99
Copy link
Owner

Thanks for the feedback - the resolution will soon be available with the next release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants