Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry communication with GitHub if first attempt failed #20

Open
trz42 opened this issue Jun 15, 2022 · 2 comments
Open

Retry communication with GitHub if first attempt failed #20

trz42 opened this issue Jun 15, 2022 · 2 comments

Comments

@trz42
Copy link
Contributor

trz42 commented Jun 15, 2022

Communicating with GitHub (e.g., adding a comment to a pull request) might fail for various reasons. For example, we once received a 401 response with the message Bad credentials. Then, retrying by restarting the bot AND redelivering the same event that eventually led to the comment action resulted in a successful operation.

Instead of just failing the bot could after waiting some time try to repeat the communication with GitHub. Only when it fails again, or repeatedly fails, it could stop trying and report the problem, e.g., via email.

@trz42
Copy link
Contributor Author

trz42 commented Jun 16, 2022

#21 addresses only the Bad credentials issue. There may be other communication problems to which the bot should react more flexibly, i.e., by retrying, by reporting, ...

@trz42
Copy link
Contributor Author

trz42 commented Oct 10, 2022

See also #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants