-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported Distribution notice on Arch-based distros #46
Comments
Thanks, I'll fix that on Sunday |
Thank you, I'll look out for it :) |
Hi, I wanted to check if there are any changes relating to this? |
Merged
(See my comment on your Pull request) |
Thanks! I think the recent merges fully resolve the issue I had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the installer gives a notification of "unsupported distribution" on EndeavourOS (which I use) based on the operating system name being "endeavouros" instead of "arch linux". However, this software would definitely also build successfully on other Arch-based distros.
My suggestion is that it case match the names of EndeavourOS, Manjaro, Garuda, and any other common Arch-based distros to be "arch linux". This is probably also the case for Ubuntu-based distros (Kubuntu, Mint, PopOS, etc), and other distros where the upstream is supported but downstream uses a different host name.
I can confirm that the repo builds fine on a vanilla arch VM, so I know it would also work on my EndeavourOS machine. Fundamentally, I think the best solution is not to query if the OS is named "arch linux" but to query if the package manager is pacman, but just case matching the distro name would resolve my issue.
The text was updated successfully, but these errors were encountered: