Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client connect timeout not being used #109

Open
m6246 opened this issue Oct 10, 2015 · 3 comments
Open

Client connect timeout not being used #109

m6246 opened this issue Oct 10, 2015 · 3 comments

Comments

@m6246
Copy link

m6246 commented Oct 10, 2015

Client.connect accepts a timeout parameter which is stored so Client.reconnect will use that, however within Client.connect at line 175, tcp.connect uses a hard-coded timeout value of 5000 where the timeout parameter should be used.
@payne911
Copy link

payne911 commented Jun 12, 2020 •
edited
Loading

@m6246 have you tried changing it to the timeout value and seeing if it works? You could submit a PR for that.

@crykn
Copy link

crykn commented Jun 13, 2020

As #connect is just calling Socket#connect this should most definitely work.

Strangely, the timeout is used for reconnecting, see here.

@payne911
Copy link

Indeed, that is strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m6246 @crykn @payne911