Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which commits to run to reproduce paper results? #352

Closed
sidmysore opened this issue Sep 9, 2021 · 2 comments
Closed

Which commits to run to reproduce paper results? #352

sidmysore opened this issue Sep 9, 2021 · 2 comments

Comments

@sidmysore
Copy link

sidmysore commented Sep 9, 2021

Hi, I've been trying to reproduce the paper's results for the MT10 setting with MTSAC (from Garage - running mtsac_metaworld_mt10.py) and I'm yet to stably get the algorithm to exceed a 40% success rate on either v1 or v2. Assuming I'm interpreting the data correctly, per the revised paper, I believe we should expect >60% success with MTSAC on v2.

I noticed in Issue #344 that you'd been working on updating the garage codebase to include the baselines and that was a few months ago and both codebases have been updated since then, so I was just wondering which versions of both codebases I should be using in order to reproduce the results from the paper.

Edit: I've tried both the current masters as well as code with commit dates closest to the v2 paper release.

@optimass
Copy link

optimass commented Dec 6, 2021

I'm having similar issues. I've been running my own version of MTSAC w/ similar hyperparameters as the one suggested in the paper's appendix and Garage code. I can't get the performance up to >60%.

Interestingly, out of 8 seeds, 3-4 runs won't learn anything and ofc this as a great impact on the aggregated performance.

I'm curious if @sidmysore sees the same behaviour.

Also, the shaded areas in the Appendix, are those standard deviations of standard errors?

@avnishn
Copy link
Contributor

avnishn commented Dec 6, 2021

Hi @optimass and @sidmysore,

Thanks for checking out Meta-World!

  1. This is the exact branch that I used to run the paper results:
    Merge mw v2 examples rlworkgroup/garage#2287

https://github.com/rlworkgroup/garage/tree/08492007d6e2d9ead9beb83a8a4247e52019ac7d/metaworld_examples

  1. The shaded areas are 95% confidence intervals.

I actually graduated, and no longer maintain Garage. The pull request/branch that I linked is what I used to run the experiments for the paper. These examples haven't been updated on master/merged onto master. You'd have to ask the current garage team about that.

Thanks,
@avnishn

cc
@krzentner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants