Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triage finschia-sdk#291 #32

Open
Tracked by #1
0Tech opened this issue Jan 11, 2024 · 1 comment
Open
Tracked by #1

Triage finschia-sdk#291 #32

0Tech opened this issue Jan 11, 2024 · 1 comment
Assignees
@0Tech
Labels
enhancement New feature or request

Comments

@0Tech
Copy link

0Tech commented Jan 11, 2024 •
edited
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Jan 11, 2024
Open
96 tasks
@0Tech 0Tech self-assigned this Jan 11, 2024
@0Tech
Copy link
Author

0Tech commented Jan 16, 2024 •
edited
Loading

It's still an issue even for the upstream (cosmos#15626). We can submit a PR onto cosmos/cosmos-sdk. The long term solution is under discussion on cometbft/cometbft.
However, I don't see a critical use case of GetBlockByHash().
The change on GetTxsEventRequest is not in backward compatible way, so if we want to adopt it, we must mind the field numbers. The PR says the modification was due to the performance, so we must make sure our client relies on this API.

@ulbqb ulbqb mentioned this issue Jan 30, 2024
Open
@0Tech 0Tech added enhancement New feature or request and removed needs-triage labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0Tech 0Tech

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0Tech