Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triage finschia-sdk#128 #5

Open
Tracked by #1
0Tech opened this issue Jan 11, 2024 · 2 comments
Open
Tracked by #1

Triage finschia-sdk#128 #5

0Tech opened this issue Jan 11, 2024 · 2 comments
Assignees
@170210
Labels
enhancement New feature or request

Comments

@0Tech
Copy link

0Tech commented Jan 11, 2024 •
edited by 170210
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Jan 11, 2024
Open
96 tasks
@170210
Copy link

170210 commented Jan 15, 2024 •
edited
Loading

This PR can be abandoned.
Although as Finschia/finschia-sdk#128 (comment) mentioned, it could be used in cli-test, it function hasn't been used so far.

This function is not used in Finschia/finschia-sdk, but it is used in the following two places in Finschia/finschia.
https://github.com/Finschia/finschia/blob/main/cli_test/test_helpers.go#L401
https://github.com/Finschia/finschia/blob/main/cli_test/test_helpers.go#L1203
Why not we migrate this function into Finschia/finschia.

@170210
Copy link

170210 commented Jan 25, 2024

Same as #18, leave a issue in Finschia/finschia.

@ulbqb ulbqb mentioned this issue Jan 25, 2024
Open
4 tasks
@170210 170210 closed this as completed Jan 30, 2024
@170210 170210 reopened this Jan 30, 2024
@170210 170210 added the enhancement New feature or request label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@170210 170210

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @170210