Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvertLocalLinks doesn't work #87

Closed
Grauenwolf opened this issue Dec 31, 2019 · 5 comments
Closed

ConvertLocalLinks doesn't work #87

Grauenwolf opened this issue Dec 31, 2019 · 5 comments

Comments

@Grauenwolf
Copy link

ConvertLocalLinks doesn't appear to be working.

Example: http://fransbouma.github.io/DocNet/markdownsupport.htm

Docnet doesn't automatically transform links to markdown files by default. To enable automatic link conversion to local markdown files, please specify the ConvertLocalLinks option in the docnet.json file file with the value true. If ConvertLocalLinks isn't specified or set to false, any link to any document in your documentation has to use the url it will get in the destination folder.

The link points http://fransbouma.github.io/DocNet/docnetjson.md (a 404) instead of http://fransbouma.github.io/DocNet/docnetjson.htm.

Testing in my own project I'm seeing similar behavior.

@FransBouma
Copy link
Owner

FransBouma commented Jan 2, 2020

Yeah it's buggy. It was an external contribution that worked in unit tests but fails in practice. The culprit is the 'PathSpecification' setting. Only if it's set to 'RelativeAsFolder' it will convert md to htm. Sigh...

At least that's what debugging tells me.... looking into it.

@FransBouma
Copy link
Owner

Fixed. Will update releases

@FransBouma
Copy link
Owner

Releases updated with 0.16.5 which should fix the problem.

@Grauenwolf
Copy link
Author

I'm still seeing the same dead link on http://fransbouma.github.io/DocNet/markdownsupport.htm

@FransBouma
Copy link
Owner

I hadn't pushed the changes to the gh-pages branch. Should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants