Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pressing Enter in search field on search page it directs to 404 page #92

Closed
chocmake opened this issue Nov 28, 2023 · 5 comments
Closed

Comments

@chocmake
Copy link

When on the search page (Docnet_search.htm) if one presses Enter within the search box it directs to a 404 page.

Noticed on the Framed site but figured it affects this project. Might be something to do with title case vs lowercase difference? As the 404 has a lowercase docnet_search.htm in the URL.

Example search query

Visual demo:
Demo

@FransBouma
Copy link
Owner

Yeah I think it's to do with the casing. In the docs page of my software (where I have written docnet for initially): https://www.llblgen.com/Documentation/5.10/LLBLGen%20Pro%20RTF/index.htm which runs on windows, no casing issues occur when I hit enter in the search box.

@FransBouma
Copy link
Owner

If you rename the docnet_search.htm to Docnet_search.htm in the URL on the 404, it works. So it's a casing issue. I think we can correct that in the template on the framed site (as it's hosted on github which does filter files on casing. why they do that is beyond me (yes it's a linux thing, but usability wise it's stupid)

@chocmake
Copy link
Author

chocmake commented Nov 28, 2023

In the docs page of my software (where I have written docnet for initially): https://www.llblgen.com/Documentation/5.10/LLBLGen%20Pro%20RTF/index.htm which runs on windows, no casing issues occur when I hit enter in the search box.

Ah so it's some Github specific implementation thing, good to know. I notice it also affects the fransbouma.github.io docs.

@FransBouma
Copy link
Owner

Indeed, as these are also running on github. Websites running on windows inherit the case insensitivity of the filesystem they're hosted on, and on unix/linux it's the same thing basically. I think it's an easy fix in the template files we're using in the framed site. Will try to fix it today :)

@FransBouma
Copy link
Owner

It's a bug in docnet, it generates that content with the docnet_search.htm fragment using a hard-coded template. Will issue a new build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants