Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggest] add new Material Tree nei page like gtce #8300

Closed
Pnc6lx opened this issue Jul 28, 2021 · 13 comments
Closed

[suggest] add new Material Tree nei page like gtce #8300

Pnc6lx opened this issue Jul 28, 2021 · 13 comments

Comments

@Pnc6lx
Copy link
Contributor

Pnc6lx commented Jul 28, 2021

i find this cool thing in gtce, so if gtnh can have similar page like gtce?

@Prometheus0000
Copy link
Member

? There's nothing there?

@Pnc6lx
Copy link
Contributor Author

Pnc6lx commented Jul 28, 2021

oh i get a mistake
GregTechCEu/GregTech#48
so here is the true link

@Prometheus0000
Copy link
Member

It definitely looks cool, and seems based off a certain wiki page type https://ftbwiki.org/Aluminium_(GregTech_5_Material) which also includes ore to dust parts (if it listed byproducts as well that would be great). But this is for JEI, and thus 1.12, so I have no idea whether it could be used in NEI or not. @mitchej123

@kumquat-ir
Copy link

author of that pull here! it is in fact based off of that wiki page layout

the first draft layout did have ore to dust in it, but that was removed because of space concerns (as well as ore processing and byproducts already having their own JEI page, I'm going to rework that one as well)

no idea what the differences in api between NEI and JEI are, so I can't really say whether it can be done in NEI

@D-Cysteine
Copy link
Contributor

Thanks for the suggestion! This has been implemented in:

Not quite as nice-looking as the JEI version, but I tried to pack as many things onto that page as I could.

Screenshot:
BlastFurnaceTemp

@Prometheus0000
Copy link
Member

  • Could you say what two icons not highlighted do? Also, are there more hidden?
  • There's also the mostly useless double+ ingots and the other plates.
  • Wouldn't it be better to display the fluids as cells? Also, I'm not sure why there's 4 slots there? Plasma? Or two used for titanium.
  • If you can, showing which coil you need would be nice, but some would end up saying inaccurate stuff later on, as you need to use the heat bonus. But I think that's only for Dr* in UHV.
  • The frame alignment bothers me
  • I guess there wasn't room to make it fancy with all the arrows? Or you don't feel like it right now.
  • I hope you can check recipes linking from them?

Looks good though.

@D-Cysteine
Copy link
Contributor

  • Gear icon: shows all diagrams. Book icon: shows basic info about the material on hover (name, chemical formula, and warnings about radioactivity, hot, cold). There aren't any more buttons hidden, though there is a related materials box to the right that doesn't show for titanium. This shows stuff like iron -> wrought iron, magnetic iron.
  • They're added in, though I'm not sure how useful they are. They do take up quite a bit of space. I took that screenshot on a minimal set of mods, so it's missing a bunch of stuff. See screenshot below for a complete view.
  • There's 4 slots because for some things, like water, up to 3 fluids are shown in there (water, steam, ice). Some of these fluids don't have cell forms available (e.g. steam), so it won't always be possible to show cells for them. Most of them (like probably 95%+) could be shown in cell form, though. Also, the blank space to the right of the fluids is used to show cracked fluids, if those exist for the material; and further to the right of that would be gems and lens, if those exist.
  • Yeah, that would be a nice feature to have. I need to see if there is a way to get the temps for the coils without hard-coding them, in case they change. Also note that the temperature display is actually not always accurate: I noticed that it says 3,600K for end steel, but the actual recipe requires 4,500K. I'm reading the property off of the GT material enum so I think it's just not getting set right (or is being overridden) in at least that one case.
  • Lol, yeah, now that you mention it it does look a bit off. The alignment makes more sense in a view with more parts shown; see screenshot below. Though I do think that that particular row could probably be arranged a bit better.
  • Not enough room, plus there's a lot of different ways to make certain things (e.g. lens can be made from flawless gem or plate), so I wasn't sure how to handle that.
  • Yup, everything is fully linked, even the fluids!

AllParts

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2021

This issue has been FixedInDev for quite a while and nobody commented in 7 days. Remove FixedInDev label or comment or this will be closed in 1 days

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2021

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 3 days

@glowredman
Copy link
Member

Is NEICustomDiagram already in the dev pack?

@bombcar
Copy link
Member

bombcar commented Dec 4, 2021

Should be since 2.1.1.4

@YannickMG
Copy link
Contributor

Good to close?

@boubou19
Copy link
Member

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants