Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oxygen processing error #8

Open
isgiddy opened this issue Apr 20, 2020 · 2 comments
Open

Oxygen processing error #8

isgiddy opened this issue Apr 20, 2020 · 2 comments

Comments

@isgiddy
Copy link
Member

isgiddy commented Apr 20, 2020 •
edited by lukegre
Loading

Describe the bug
Some change in compatibility with oxygen processing and outlier_bounds_iqr
which results in an error

To Reproduce
Steps to reproduce the behavior:

  1. try calc_oxygen function
  2. IndexError: arrays used as indices must be of integer (or boolean) type

Screenshots
Screenshot 2020-04-20 at 15 57 04

Desktop (please complete the following information):

  • OS: [e.g. iOS]

Additional context
I managed to make it work by editing the problem section to agree with iqr function output. Not sure if its correct?
mask = outlier_bounds_iqr(Y, multiplier=1.5)
ratios = Y[Y==mask] / X[Y==mask,1]
@lukegre
Copy link
Member

lukegre commented Sep 22, 2020

@isgiddy,
Have you managed to look into this any more? And do you think you'll be able to tackle this?

@isgiddy
Copy link
Member Author

isgiddy commented Sep 22, 2020

@luke-gregor I have used the fixed version I worked on. I'll send you a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukegre @isgiddy