From 6756bda689632ba56b89fa7b96d33638610f795c Mon Sep 17 00:00:00 2001 From: Marcin Pietruszka Date: Tue, 20 Sep 2022 09:02:00 +0200 Subject: [PATCH] Fix audio recording issues (#12338) --- packages/story-editor/src/components/mediaRecording/audio.js | 4 ++++ .../story-editor/src/components/mediaRecording/provider.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/story-editor/src/components/mediaRecording/audio.js b/packages/story-editor/src/components/mediaRecording/audio.js index a73dd4ddae57..8ce91eb29970 100644 --- a/packages/story-editor/src/components/mediaRecording/audio.js +++ b/packages/story-editor/src/components/mediaRecording/audio.js @@ -53,6 +53,10 @@ const AudioAnalyser = ({ source }) => { } useEffect(() => { + if (source.getAudioTracks().length === 0) { + return () => {}; + } + const audioNode = audioContextRef.current.createMediaStreamSource(source); audioNode.connect(analyserRef.current); diff --git a/packages/story-editor/src/components/mediaRecording/provider.js b/packages/story-editor/src/components/mediaRecording/provider.js index e47fea678376..8111755aa5fd 100644 --- a/packages/story-editor/src/components/mediaRecording/provider.js +++ b/packages/story-editor/src/components/mediaRecording/provider.js @@ -160,7 +160,7 @@ function MediaRecordingProvider({ children }) { }); const currentRecorder = - videoEffect && videoEffect !== 'none' + videoEffect && videoEffect !== 'none' && hasVideo ? { ...mediaRecorder, inputStatus: mediaRecorder.status,