Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions: Improve revision count check #12313

Closed
swissspidy opened this issue Sep 14, 2022 · 0 comments · Fixed by #12317
Closed

Revisions: Improve revision count check #12313

swissspidy opened this issue Sep 14, 2022 · 0 comments · Fixed by #12317
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

#12197 adds a link to revisions if there's 1 or more revision.

WordPress core does it only if there's 2 or more:

https://github.com/WordPress/gutenberg/blob/a71352ea2eaad71af5de551b343fc6aa65e049b6/packages/editor/src/components/post-last-revision/check.js#L17

We should do the same.

Alternatives Considered

Additional Context
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature P2 Should do soon Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP P1 High priority, must do soon and removed P2 Should do soon labels Sep 14, 2022
@swissspidy swissspidy mentioned this issue Sep 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix revisions count check GoogleForCreators/web-stories-wp
1 participant
@swissspidy