Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxSimpleCombo: possibility to not open dropdown on clear #11871

Closed
Timmeeeey opened this issue Jul 15, 2022 · 10 comments · Fixed by #12790
Closed

IgxSimpleCombo: possibility to not open dropdown on clear #11871

Timmeeeey opened this issue Jul 15, 2022 · 10 comments · Fixed by #12790
Assignees
Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Timmeeeey
Copy link

Is your feature request related to a problem? Please describe.

When you clear a IgxSimpleCombo then the dropdown opens.
When you clear a IgxCombo then the dropdown doesn't open.

Describe the solution you'd like

It should be possible to configure the IgxSimpleCombo to not open the dropdown on clear.

@RivaIvanova
Copy link
Member

Hello @Timmeeeey,

A similar behavior like the one of the IgxCombo could be achieved on application level by using the simple combo’s opening and selectionChanging events and canceling the opening event when the item is deselected, i.e., cleared via the “X” icon. Here could be found a sample demonstrating this approach.

However, this does require additional lines of code and perhaps having a way to configure the simple combo’s dropdown to either open or not is a better option.

@Timmeeeey
Copy link
Author

Hi @RivaIvanova,
a boolean input like openOnClear would be nice but the code you provided is ok for me.
Thank you.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 24, 2022
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Sep 26, 2022
@teodosiah teodosiah assigned teodosiah and georgianastasov and unassigned Lipata Oct 7, 2022
@georgianastasov georgianastasov added the 🛠️ status: in-development Issues and PRs with active development on them label Oct 10, 2022
@georgianastasov georgianastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 12, 2022
@Lipata
Copy link
Member

Lipata commented Nov 10, 2022

Hey, @Timmeeeey, as you see there is a PR that adds such options for both igx-combo and igx-simple-combo. However, we are still considering if adding an option is necessary because having an event is more than enough - it is possible to abandon the PR. The more important in that case is what should happen when the clear button is clicked - either to open the drop-down or not, something that is different between igx-combo and igx-simple-combo and should be consistent.

Soon there will be an effort for a combo component in our web-components package, so we will discuss the best UX for the clear button and will transform the solution here. I hope till then you can use the solution @RivaIvanova has suggested you.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jan 10, 2023
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Jan 10, 2023
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Mar 12, 2023
@radomirchev
Copy link
Contributor

@Lipata , @teodosiah do you have update on that issue?

@Lipata
Copy link
Member

Lipata commented Mar 14, 2023

The combo in the web-components was designed so that the clear button never opens the drop-down - this is for both multiple selection and single selection mode (in web-components it is one component). Once the value is cleared then one additional click will open the drop-down. I think this is a good solution and it was agreed by our design team that this is a good approach.

It seems that we can change the simple combo in angular to behave the same way - not to open the drop-down on clear, and if somebody wants such a thing we will provide him with an application solution. @kdinev do you think that we can introduce such a behavioral change for the simple-combo and in that way sync it with the combo in angular and combo in web components?

@kdinev
Copy link
Member

kdinev commented Mar 15, 2023

Seems like currently the igx-simple-combo and igx-combo have an inconsistent behavior. Does the specification explicitly state that the drop down opens on clear with the simple combo? If yes, then it's an expected behavior, if not, then it should be consistent with the igx-combo component.

@Lipata
Copy link
Member

Lipata commented Mar 15, 2023

The igx-simple-combo specification in angular doesn't state that drop down opens on clear, so we will proceed with changing that behavior in the igx-simple-combo and align it with igx-combo and the igc-combo. @teodosiah, @RivaIvanova we can proceed with the implementation and also provide an application scenario that will cover the old behavior in the igx-simple-combo.

@Lipata Lipata removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. status: inactive Used to stale issues and pull requests labels Mar 15, 2023
@georgianastasov georgianastasov added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 20, 2023
@georgianastasov georgianastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
7 participants