Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup: add label #12890

Closed
Timmeeeey opened this issue Apr 17, 2023 · 7 comments · Fixed by #13176 or #13221
Closed

RadioGroup: add label #12890

Timmeeeey opened this issue Apr 17, 2023 · 7 comments · Fixed by #13176 or #13221
Assignees

Comments

@Timmeeeey
Copy link

Is your feature request related to a problem? Please describe.

I'm using fluent design and it's currently not possible to add a label to a RadioGroup.

Describe the solution you'd like

Please add the possibility to add a label to RadioGroup like in other components.

Additional context

image

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jun 26, 2023
@SisIvanova SisIvanova added 👀 status: in-review Issue is currently being reviewed and removed 🆕 status: new status: inactive Used to stale issues and pull requests labels Jun 26, 2023
@SisIvanova
Copy link
Collaborator

Here is a sample demonstrating how to use the IgxLabelDirective as a radio-group label. Do you need something besides that?

https://stackblitz.com/edit/c6fqyt?file=src%2Fapp%2Fradio-group-sample%2Fradio-group-sample.component.html

@Timmeeeey
Copy link
Author

hi @SisIvanova
I don't see any IgxLabelDirective in the example.
Can you use igxLabel without a IgxInputGroup?

@SisIvanova
Copy link
Collaborator

Hi @Timmeeeey
Can you please explain to us what you need the radio group label for so we can decide how to proceed with this feature request? You want a label that is just styled properly or you expect specific functionality?

@Timmeeeey
Copy link
Author

In some cases radio groups need labels for reasons of comprehensibility.
This label should look like all the other labels.

When displayed next to an input it would be nice if the radio buttons are vertically aligned with inputs for aesthetic reasons.
But I can just add some padding if this will not be the case.

Example:
image
image

@simeonoff simeonoff linked a pull request Jul 4, 2023 that will close this issue
14 tasks
@Timmeeeey
Copy link
Author

@SisIvanova
If I use the igxLabel directive then the label doesn't quite look like the label of the input.
Besides the asterisk for required input is missing.

current:
image

required:
image

@SisIvanova
Copy link
Collaborator

Hi @Timmeeeey
Our team is aware of this issue and we're planning to fix it soon. The igxLabel directive has always been part of the igx-input-group that's why when you want to use it separately some styles are missing. In a future release, we will extract the igxLabel directive and all of its styles from the igx-input-group theme so that all labels will look the same. Until then, you can use this sample to style the Radio Group Label in the same way as the Input Label in Fluent theme:
https://stackblitz.com/edit/c6fqyt-kbkxal?file=src%2Fapp%2Fradio-group-sample%2Fradio-group-sample.component.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants