Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper - Differences with the step indicаtor between WC and Angular #12988

Closed
viktorkombov opened this issue Apr 26, 2023 · 4 comments
Closed

Comments

@viktorkombov
Copy link
Contributor

Description

There are differences with the step indicаtor between WC and Angular when the indicator is customized:

Angular:

image

WC:

image

Steps to reproduce

  1. Download and run the following samples - Angular, WC.
  2. See the differences.

Result

There are differences with the step indicator between WC and Angular.

Expected result

There should not be any differences.

@desig9stein
Copy link
Contributor

desig9stein commented May 5, 2023

@simeonoff, @viktorkombov This issue should be a feature request in the Angular repo, the stepper in WebC follows the design handoff. I noticed that the Wiki in angular is updated to use the same handoff but nobody logged a feature request to update the design accordingly. I believe that the person who updated the spec was supposed to log an issue.

@simeonoff simeonoff transferred this issue from IgniteUI/igniteui-webcomponents May 9, 2023
@simeonoff simeonoff added 🧰 feature-request and removed status: not-a-bug 👀 status: in-review Issue is currently being reviewed labels May 9, 2023
@viktorkombov
Copy link
Contributor Author

@desig9stein, in the design handoff there is a background when the indicator is customized but we cannot see it in WC:

Handoff:

image

WC:

image

What I also have observed is that in both - Angular and WC, the optional step doesn't have differences with the regular step, which is not the same in the design handoff where the optional step is with different background in the indicator:

Handoff:

image

WC:

image

@desig9stein
Copy link
Contributor

design handoff

@viktorkombov there is a gray background when the step is complete, when the step is optional or Incomplete they look the same, when the step is selected there is a blue background that has the higher precedence and always overrides the other states colors.

WC
Screenshot 2023-05-18 at 11 45 14

Angualr
Screenshot 2023-05-18 at 11 53 53

Design
Screenshot 2023-05-18 at 11 54 50

@viktorkombov
Copy link
Contributor Author

@viktorkombov there is a gray background when the step is complete, when the step is optional or Incomplete they look the same, when the step is selected there is a blue background that has the higher precedence and always overrides the other states colors.

Yeah, my mistake. But the issue with the missing background of the customized indicators still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants