Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Display Density Token in favour of --ig-size CSS variable #13389

Closed
15 of 16 tasks
simeonoff opened this issue Aug 21, 2023 · 0 comments · Fixed by #13399
Closed
15 of 16 tasks

Deprecate the Display Density Token in favour of --ig-size CSS variable #13389

simeonoff opened this issue Aug 21, 2023 · 0 comments · Fixed by #13399
Assignees
Labels
📈 enhancement ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@simeonoff
Copy link
Collaborator

simeonoff commented Aug 21, 2023

The currently exposed display density token for setting the size of various components should be deprecated in favour of the --ig-size CSS variable. The variable should be used to size various components. This will reduce prop drilling as well as simplify the styles by eventually removing any classes related to display density/size(i.e. --compact, --cosy).

This issue requires us to evaluate all components that currently use the display density token and remove class bindings based on the token. The --ig-size property should be used to control how components are sized, including other components internal to any parent component. This can be achieved by setting dimensions of various elements/components by using the sizable mixin or function where needed.

Affected components:

@simeonoff simeonoff self-assigned this Aug 21, 2023
@simeonoff simeonoff added 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new 🛠️ status: in-development Issues and PRs with active development on them labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant