Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit a date cell if grid's data is of ISO String or Numeric types #8256

Closed
hanastasov opened this issue Oct 1, 2020 · 8 comments
Closed
Assignees
Labels

Comments

@hanastasov
Copy link
Contributor

hanastasov commented Oct 1, 2020

  • igniteui-angular version: 10.0.x

Steps to reproduce

  1. Go to gridCellEditing dev sample
  2. Edit first date value in the data source:
    OrderDate: new Date('2012-02-12').toISOString()
  3. Double click the first cell in the OrderDate column to enter edit mode

Result

An error is thrown in the console

Expected result

Be able to succesfully edit the cell.

@zdrawku
Copy link
Contributor

zdrawku commented Oct 6, 2020

This also applies to the ExcelStyleFiltering feature and it is not only when ISO String type data is being used. The same error is thrown when number type data is used as Date (a numerical representation of the milliseconds as a unit of measurement could be used)

Steps to reproduce:

  1. Open the sample
  2. Open the excel style filter dialog for Order date column
  3. Error is thrown - toDateString() is not a function

image

@zdrawku zdrawku changed the title Can't edit a date cell, if date is in ISO string format Can't edit a date cell or filter data, if grid's data is of ISO String or Numeric types Oct 6, 2020
@zdrawku
Copy link
Contributor

zdrawku commented Oct 9, 2020

@ddincheva @hanastasov add your comments as well

@hanastasov
Copy link
Contributor Author

Also, when date values come in as string/numbers, sorting and filtering are not correct. Sorting/filtering algortihms need to know if the value is date in number/string format in order to parse it to true Date object.

@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new 🛠️ status: in-development Issues and PRs with active development on them labels Oct 13, 2020
@hanastasov hanastasov removed their assignment Oct 13, 2020
@Lipata
Copy link
Member

Lipata commented Oct 13, 2020

Related to #6994

@zdrawku zdrawku assigned Lipata and unassigned zdrawku Oct 13, 2020
@zdrawku zdrawku changed the title Can't edit a date cell or filter data, if grid's data is of ISO String or Numeric types Can't edit a date cell if grid's data is of ISO String or Numeric types Oct 13, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 13, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Dec 13, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Feb 12, 2021
@ddincheva ddincheva removed the status: inactive Used to stale issues and pull requests label Feb 12, 2021
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Apr 14, 2021
@ddincheva ddincheva removed the status: inactive Used to stale issues and pull requests label Apr 14, 2021
@Lipata Lipata mentioned this issue Apr 14, 2021
14 tasks
@zdrawku zdrawku assigned zdrawku and ddincheva and unassigned Lipata and zdrawku Apr 22, 2021
@ddincheva
Copy link
Contributor

This problem has been addressed with PR #9160 and is no longer reproducible on the master branch.

@ddincheva ddincheva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants