Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable cell styling support #9630

Closed
Eralmidia opened this issue Jun 2, 2021 · 8 comments · Fixed by #9695 or #9719
Closed

Editable cell styling support #9630

Eralmidia opened this issue Jun 2, 2021 · 8 comments · Fixed by #9695 or #9719
Assignees
Labels
grid: cell-editing 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Eralmidia
Copy link

Is your feature request related to a problem? Please describe.

When having a grid with a lot of columns, it can be tricky for the user to easily determine which columns are editable (when in row edit mode).

Describe the solution you'd like

The ability to style the background color of editable cells to a different color than non-editable (read-only) cells.

@StefanIvanov
Copy link
Contributor

StefanIvanov commented Jun 7, 2021

@Eralmidia thanks for logging this request. Would you say that a style for the text of editable/non-editable cells for the row under edit mode at the moment would work for you as well? Imagine the most simple scenario where cells belonging to non-editable columns have a disabled-style text, while editable ones have a more active look i.e. the current style used for all cells on the edited row?
In your case do you want to make this difference very prominent or a more subtle approach like the above is also viable for you?

@Eralmidia
Copy link
Author

@StefanIvanov Yes, absolutely, that would work fine as well 👍

@StefanIvanov
Copy link
Contributor

We have updated the spec and will be able to start implementing the design

@Eralmidia
Copy link
Author

Looks good 👍 One related question about editing: In the spec, the edited field has an underline, like the input fields does.
image

This doesn't seem to be the default. Is there a setting for this, or are you using custom templates with igx-inputs?

@StefanIvanov
Copy link
Contributor

I noticed this too, the spec needs updating that removes that underline since it is outdated now :)

@desig9stein desig9stein added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 10, 2021
@desig9stein desig9stein added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 10, 2021
@Eralmidia
Copy link
Author

@StefanIvanov Just a thought on this one. While the solution of disabled looking text works for row editing, it wouldn't help much in a "Add row scenario", where no fields are already filled out. In that case, something like editable background colors might have been better. Don't know if this is a scenario you have considered?

@StefanIvanov
Copy link
Contributor

@Eralmidia we will discuss this scenario internally, the reason we wanted to avoid using the background was because of a number of other features that do so such as selection, active cell, and conditional cell styling, where people often define background styles based on the value in a cell.

@StefanIvanov
Copy link
Contributor

Reopening this issue in order to propagate the changes to the row adding scenario
@desig9stein

@StefanIvanov StefanIvanov added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Jun 15, 2021
@desig9stein desig9stein added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: cell-editing 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
5 participants