Handle errors during type conversions

[ImVexed]

In many places throughout the code we have to type cast to and from cgo types.

Currently (ex.), we're not handling errors during those conversions and will likely lead to panics during edge cases.

[goku321]

Hi @ImVexed if you need help with this one, I can try my hands on this.

[ImVexed]

That'd be appreciated @goku321 I'm tied up until next weekend but should be able to review any pull request related to this in the meantime.

[goku321]

Great @ImVexed ! I'll start getting familiar with the code.

[ImVexed]

@goku321 Any progress on this?

[goku321]

Hi @ImVexed I moved to a different city few days back and just getting settled here so couldn't make progress on this. If it's okay, I can work on it this coming weekend. Thanks for your patience.

[ImVexed]

@goku321 Absolutely! No worries. Was mainly just a reminder in case it fell off your radar and others were interested in picking it up.

[goku321]

Hi @ImVexed I have made a couple of changes and would like to get your inputs just to know if I'm heading in the right direction or not. Here's the link to the commit

[ImVexed]

That code won't work the way you're thinking. JSValueMake* functions all return JSValueRef if I remember correctly. But more than that there's no need for us to ascertain their type.

I'm more concerned with places like https://github.com/ImVexed/muon/blob/master/muon.go#L215 and https://github.com/ImVexed/muon/blob/master/muon.go#L327 where we are blindly casting objects which will likely end in runtime panics given edge cases.